Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] firefox issues #510

Closed
AwakenTheJaken opened this issue Dec 9, 2023 · 7 comments · Fixed by #511
Closed

[🐞] firefox issues #510

AwakenTheJaken opened this issue Dec 9, 2023 · 7 comments · Fixed by #511
Labels
bug Something isn't working

Comments

@AwakenTheJaken
Copy link

Describe the bug

There has been no updates or any contributors popping in to help with issues. Firefox for one... Our dev team is pretty disappointed as we spent many hours implementing and testing this, Firefox is rendered unusable on our site, but wait... there's more!

Reproduction

http://localhost:3000

Steps to reproduce

Using the library

Browser Info

Chrome

Additional Information

Can we get a absolute if this project has been archived? Also there are many many bugs, Adding this to our application had a huge impact on our numbers on GA4, CSP is implemented correctly yet things are falling through the cracks. Our team has since removed this from our stack due to the issues above.

@AwakenTheJaken AwakenTheJaken added the bug Something isn't working label Dec 9, 2023
@mhevery
Copy link
Contributor

mhevery commented Dec 10, 2023

There are several reasons why there have not been many updates.

  1. people file issues without reproduction.
  2. The nature of this project is that any reproduction often involves debugging 3rd-party minified code, which is extremely hard and time-consuming.
  3. We have been putting most of our efforts into Qwik.

Our hope is that as we grow and gain more resources, we should be able to do a better job supporting it.

Have you tried to create a PR to fix an issue?

@emish89
Copy link
Contributor

emish89 commented Dec 11, 2023

I understand your points but I can totally understand the user that opened this.

The firefox bug is really making the library useless and can be a big problem for who implemented it and now needs to migrate until resolution.
...and I think there are a lot of example of codes to debug it.

I don't know the effort required but can really help to face this issue with an high priority, because firefox is widely used and the error cannot be bypassed

@thejackshelton
Copy link
Member

I understand your points but I can totally understand the user that opened this.

The firefox bug is really making the library useless and can be a big problem for who implemented it and now needs to migrate until resolution. ...and I think there are a lot of example of codes to debug it.

I don't know the effort required but can really help to face this issue with an high priority, because firefox is widely used and the error cannot be bypassed

Agreed that this is a big problem. Happy to look into a PR someone makes to fix it.

@emish89
Copy link
Contributor

emish89 commented Dec 11, 2023

Agreed that this is a big problem. Happy to look into a PR someone makes to fix it.

Well ok, understood.

But this seems confirming what the user first said.

Is this project still maintained? If even high priority bugs are ignored after months, only waiting for external PRs, I think is a fair question.

@emish89
Copy link
Contributor

emish89 commented Dec 12, 2023

#511

can you please review this? I don't know why the setTimeouts are needed but without them seems working on firefox and chrome.

@thejackshelton @mhevery

@mhevery
Copy link
Contributor

mhevery commented Dec 13, 2023

#511

can you please review this? I don't know why the setTimeouts are needed but without them seems working on firefox and chrome.

Oh, that is interesting and exciting! Any chance you could add a test to https://github.com/BuilderIO/partytown/tree/main/tests/platform which shows that the issue has been fixed?

@gioboa gioboa linked a pull request Dec 29, 2023 that will close this issue
@gioboa gioboa changed the title [🐞] Is this project dead? [🐞] firefox issues Dec 29, 2023
@gioboa
Copy link
Member

gioboa commented Dec 29, 2023

#511 close this one

@gioboa gioboa closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants