Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad error message when setting the template of a qube to a qube that doesn’t exist #6966

Closed
DemiMarie opened this issue Oct 13, 2021 · 4 comments · Fixed by QubesOS/qubes-core-admin#571
Assignees
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.1-dom0-stable r4.2-host-stable ux User experience
Milestone

Comments

@DemiMarie
Copy link

How to file a helpful issue

Qubes OS release

R4.1

Brief summary

[user@dom0 ~]$ qvm-prefs sys-firewall template nonexistantqube
usage: qvm-prefs [--verbose] [--quiet] [--help] [--help-properties] [--hide-default] [--get] [--set] [--default] VMNAME [PROPERTY] [VALUE]
qvm-prefs: error: no such property: 'template'

even though the command was used correctly and template is in fact a property.

Steps to reproduce

See above 🙂

Expected behavior

A better error message, such as “There is no qube named ‘nonexistantqube’”. If the request is made from dom0, a list of qubes with similar names could be displayed.

Actual behavior

Error message is no such property: 'template', even though the property template does exist.

@DemiMarie DemiMarie added T: bug ux User experience P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Oct 13, 2021
@unman
Copy link
Member

unman commented Oct 13, 2021 via email

@andrewdavidwong andrewdavidwong added C: core diagnosed Technical diagnosis has been performed (see issue comments). labels Oct 14, 2021
@andrewdavidwong andrewdavidwong added this to the Release 4.0 updates milestone Oct 14, 2021
@andrewdavidwong andrewdavidwong added the eol-4.0 Closed because Qubes 4.0 has reached end-of-life (EOL) label Aug 5, 2023
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2023
@HW42 HW42 reopened this Dec 11, 2023
@HW42 HW42 self-assigned this Dec 11, 2023
@andrewdavidwong andrewdavidwong added affects-4.1 This issue affects Qubes OS 4.1. pr submitted A pull request has been submitted for this issue. and removed eol-4.0 Closed because Qubes 4.0 has reached end-of-life (EOL) labels Dec 12, 2023
@andrewdavidwong andrewdavidwong removed this from the Release 4.0 updates milestone Dec 12, 2023
@andrewdavidwong andrewdavidwong added this to the Release 4.2 milestone Dec 16, 2023
marmarek pushed a commit to QubesOS/qubes-core-admin that referenced this issue Jan 20, 2024
Trying to set a VMProperty (netvm, template, ...) to a non-existing VM
previously raised a QubesVMNotFoundError. While this is not wrong
qvm-prefs can't distinguish this from other cases (for example see [1])
so instead raise QubesPropertyValueError with a matching error message.

Fixes QubesOS/qubes-issues#6966

[1]: https://github.com/QubesOS/qubes-core-admin-client/blob/e7892560a3a64b924c20dd81bb7f718b5b1c49de/qubesadmin/base.py#L382

(cherry picked from commit 83b1959)
@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-admin (including package qubes-core-dom0-4.1.35-1.fc32) has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-admin (including package qubes-core-dom0-4.1.36-1.fc32) has been pushed to the r4.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.1-dom0-stable r4.2-host-stable ux User experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants