-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad error message when setting the template of a qube to a qube that doesn’t exist #6966
Comments
On Wed, Oct 13, 2021 at 07:33:12AM -0700, Demi Marie Obenour wrote:
[How to file a helpful issue](https://www.qubes-os.org/doc/issue-tracking/)
### Qubes OS release
R4.1
### Brief summary
```
***@***.*** ~]$ qvm-prefs sys-firewall template nonexistantqube
usage: qvm-prefs [--verbose] [--quiet] [--help] [--help-properties] [--hide-default] [--get] [--set] [--default] VMNAME [PROPERTY] [VALUE]
qvm-prefs: error: no such property: 'template'
```
even though the command was used correctly and `template` is in fact a property.
### Steps to reproduce
See above 🙂
### Expected behavior
A better error message, such as ???There is no qube named ???nonexistantqube??????. If the request is made from dom0, a list of qubes with similar names could be displayed.
### Actual behavior
Error message is `no such property: 'template'`, even though the property `template` does exist.
|
This comment was marked as outdated.
This comment was marked as outdated.
Trying to set a VMProperty (netvm, template, ...) to a non-existing VM previously raised a QubesVMNotFoundError. While this is not wrong qvm-prefs can't distinguish this from other cases (for example see [1]) so instead raise QubesPropertyValueError with a matching error message. Fixes QubesOS/qubes-issues#6966 [1]: https://github.com/QubesOS/qubes-core-admin-client/blob/e7892560a3a64b924c20dd81bb7f718b5b1c49de/qubesadmin/base.py#L382 (cherry picked from commit 83b1959)
Automated announcement from builder-github The component
|
Automated announcement from builder-github The component
Or update dom0 via Qubes Manager. |
How to file a helpful issue
Qubes OS release
R4.1
Brief summary
even though the command was used correctly and
template
is in fact a property.Steps to reproduce
See above 🙂
Expected behavior
A better error message, such as “There is no qube named ‘nonexistantqube’”. If the request is made from dom0, a list of qubes with similar names could be displayed.
Actual behavior
Error message is
no such property: 'template'
, even though the propertytemplate
does exist.The text was updated successfully, but these errors were encountered: