Fix error message for non-existing VM passed to a VMProperty #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to set a VMProperty (netvm, template, ...) to a non-existing VM previously raised a QubesVMNotFoundError. While this is not wrong qvm-prefs can't distinguish this from other cases (for example see [1]) so instead raise QubesPropertyValueError with a matching error message. Fixes QubesOS/qubes-issues#6966 [1]: https://github.com/QubesOS/qubes-core-admin-client/blob/e7892560a3a64b924c20dd81bb7f718b5b1c49de/qubesadmin/base.py#L382
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
- Coverage 68.42% 68.40% -0.02%
==========================================
Files 56 56
Lines 11163 11163
==========================================
- Hits 7638 7636 -2
- Misses 3525 3527 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
If I understand the failing codeconv report correctly the complaints is that now the 2 lines in the initializer of QubesVMNotFoundError are no longer called when running the tests. For the changed code this is expected. Adding a tests for another, unrelated, path where QubesVMNotFoundError is instantiated seems out of scope for this PR. |
marmarek
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to set a VMProperty (netvm, template, ...) to a non-existing VM previously raised a QubesVMNotFoundError. While this is not wrong qvm-prefs can't distinguish this from other cases (for example see 1) so instead raise QubesPropertyValueError with a matching error message.
Fixes QubesOS/qubes-issues#6966