Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCA section in SVD lecture #397

Merged
merged 8 commits into from
Dec 4, 2024
Merged

PCA section in SVD lecture #397

merged 8 commits into from
Dec 4, 2024

Conversation

sidd3888
Copy link
Contributor

@sidd3888 sidd3888 commented Jul 1, 2024

Made the changes referenced in issue #396.

@HumphreyYang
Copy link
Collaborator

Many thanks @sidd3888 for contributing! We will get this merged very soon once we get green ticks.

@mmcky
Copy link
Contributor

mmcky commented Nov 18, 2024

thanks for reviewing @HumphreyYang -- greatly appreciated.

thanks @sidd3888 for the PR.

@HumphreyYang would you mind to review the merge conflict?

@HumphreyYang
Copy link
Collaborator

thanks for reviewing @HumphreyYang -- greatly appreciated.

thanks @sidd3888 for the PR.

@HumphreyYang would you mind to review the merge conflict?

Thanks @mmcky,

I fix the lecture bayes_nonconj because it is not building properly. I will wait to see if #395 is building : )

If #395 builds, I will revert my changes in favor of the main.

@mmcky
Copy link
Contributor

mmcky commented Nov 27, 2024

thanks @HumphreyYang. This OK to merge now?

@mmcky
Copy link
Contributor

mmcky commented Dec 4, 2024

thanks again @sidd3888 and @HumphreyYang

@mmcky mmcky merged commit 101e584 into QuantEcon:main Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants