-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: update @jit(nopython=True) to @jit with numba>=0.59 #395
Conversation
|
There are a few speed regressions when applying these changes (right is this PR, left is current live site) @kp992 would you have any time to review this and see what might be causing the slowdown in execution speed? |
Checking this from numba repo: And |
Hmm, I guess there can 2 reasons behind this:
|
@kp992 I don't fully understand your comments.
This PR is strictly update the Numba jit so I don't understand why GPU is involved?
For any lecture that has had code change then the cache should be invalidated and the lecture is run fresh. Perhaps we can link up and discuss this? |
Thanks @mmcky, I can try looking into it in more details and discuss on this. |
@mmcky Can we re-run and see if the time results still differ? Maybe sometimes we might have hit some outlier? |
@kp992 there are still large differences: |
I will try to debug what's creating these differences. |
|
@kp992 and @HumphreyYang it looks like many of the large differences have resolved in the latest run and versions of |
Thanks @kp992. This looks great and clean! |
This PR updates
njit
to usejit
now thatnumba>=0.59
andnopython=True
is now the default behaviour of thejit
This resolves QuantEcon/meta#112 for this lecture series