Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[intro_supply_demand] Chinese in plot #31

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Conversation

longye-tian
Copy link
Contributor

Hi Matt @mmcky ,

This pull request is to fix the chinese display issue #30 in plot using method in #5 .

Best,
Longye

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for playful-platypus-17d3bb ready!

Name Link
🔨 Latest commit 52c14d6
🔍 Latest deploy log https://app.netlify.com/sites/playful-platypus-17d3bb/deploys/66ec2448f792780008a1ed09
😎 Deploy Preview https://deploy-preview-31--playful-platypus-17d3bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 19, 2024

@github-actions github-actions bot temporarily deployed to pull request September 19, 2024 10:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 19, 2024 10:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 19, 2024 12:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 19, 2024 12:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 19, 2024 12:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 19, 2024 12:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 19, 2024 13:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 19, 2024 13:34 Inactive
@longye-tian longye-tian added the bug Something isn't working label Sep 19, 2024
Comment on lines +59 to +61
# List all available font names
font_list = [f.name for f in matplotlib.font_manager.fontManager.ttflist]
print(font_list)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@longye-tian do we need these lines and information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matt @mmcky ,

This is just to know what font are available. So they are temporary, just for me to fix things later. So they will be deleted at the end.

I'm still trying to workout a solution for this problem.

I'll let the team know if I fix it.

Best,
Longye

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry - thanks @longye-tian I thought this was ready. My mistake. Take your time. Thanks for your work.

@HumphreyYang
Copy link
Contributor

HumphreyYang commented Sep 22, 2024

Hi guys,

Please kindly see my comments here: #5 (comment)

I managed to make Chinese characters show on my Linux machine which might cause the same issue on the Linux server.

This might need some help from @mmcky to setup the same procedure on the docker : )

@mmcky
Copy link
Contributor

mmcky commented Sep 27, 2024

@longye-tian @HumphreyYang I'm not sure what is needed here. Can you let me know if I need to make some changes on the infrastructure side?

@HumphreyYang
Copy link
Contributor

@longye-tian @HumphreyYang I'm not sure what is needed here. Can you let me know if I need to make some changes on the infrastructure side?

Hi @mmcky,

Nothing needs to be done now. It was my old solution to show Chinese in the matplotlib : )

@mmcky
Copy link
Contributor

mmcky commented Sep 30, 2024

thanks @longye-tian

@mmcky mmcky merged commit 8e700ae into main Sep 30, 2024
7 checks passed
@mmcky mmcky deleted the intro-demand-supply-fix branch September 30, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants