Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: log ETA calculation #7994

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented May 3, 2024

Description

This pull request removes the calculation of ETA (Estimated Time of Arrival) logs, as it was found to be inaccurate when dealing with certain security types. Instead, the PR retains information about the downloading progress of each symbol.

Related Issue

N/A

Related PR

Motivation and Context

The ETA log calculation was causing inaccuracies, particularly when handling specific security types. Removing this calculation simplifies the process and ensures that users receive accurate information about the download progress. By retaining information about downloading each symbol, users can still monitor the progress effectively without relying on potentially misleading ETA estimation

Requires Documentation Change

N/A

How Has This Been Tested?

This change has been tested by running existing tests to ensure that the functionality remains intact after removing the ETA log calculation. Additionally, manual testing has been performed through the execution of the downloader launcher application to verify that the download progress information is displayed correctly for each symbol.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes requested a review from Martin-Molinero May 3, 2024 14:32
@Romazes Romazes self-assigned this May 3, 2024
@Martin-Molinero Martin-Molinero merged commit 9fad556 into QuantConnect:master May 3, 2024
6 of 7 checks passed
@Romazes Romazes deleted the remove-data-downloader-eta-calculation branch September 17, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants