Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Group Symbol and Total Time Execution Logging for Downloading Canonical Data #7984

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Apr 30, 2024

Description

This pull request introduces two new features:

  1. Group Symbol Addition: When downloading canonical data, a group symbol is now included to improve data organization and clarity.
  2. Total Time Execution Logging: Total time execution of the download provider is now logged, aiding in performance monitoring and optimization.

Related Issue

N/A

Related PR

Motivation and Context

By adding a group symbol, we aim to enhance the user experience by providing clearer organization of downloaded canonical data. Additionally, logging the total time execution of the download provider will help us monitor performance and identify potential areas for improvement.

Requires Documentation Change

How Has This Been Tested?

  • Unit Testing: Writing unit tests to cover different scenarios and ensure code reliability and stability.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Romazes added 2 commits April 30, 2024 16:33
feat: log total time execution of download provider
test: right keeping of cannonicial data
@Romazes Romazes requested a review from Martin-Molinero April 30, 2024 18:22
@Romazes Romazes self-assigned this Apr 30, 2024
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Martin-Molinero Martin-Molinero merged commit ef23d7b into QuantConnect:master May 1, 2024
7 checks passed
@Romazes Romazes mentioned this pull request May 3, 2024
11 tasks
@Romazes Romazes deleted the fix-download-data-provider-save-option branch September 17, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants