Fix #505 : Remove "empty filter" row #511
Conversation
|
This doesn't seem to fix it:
To reiterate: there shouldn't be any line in the "Metadata Filters" section by default and one should only appear if the user clicks the "+" button. Functionalitywise, in case there is no line it should just work as right now if it displays "Empty Filter". |
|
I have replaced the string "Empty Filter" by an empty string, so the fact you see it makes me think you might have used the wrong branch. Is that possible ? |
It seems it is. No idea how that happened given that I even pushed a merge commit 6ba57ab 😵💫 |
There was a problem hiding this comment.
-
For source storages that do not have any corpus available, can we disablethe "+" button or potentially even remove it or the "Metadata Filters" section completely?
-
When selecting a source storage that has multiple corpora, selecting a corpus from the dropdown menu creates and empty filter that does not go away automatically
Screencast.from.2024-12-12.16-55-09.webm
This seems just like an UI issue, because the chat can be started with the row present and is correctly using no metadata filter.
Fix #505 : Remove "empty filter" row
I have kept the line
if filter_row.key != NO_FILTER_KEYas it is necessary to create a new chat after adding a first filter row, which appears empty by default. Run it and tell me what needs to be improved.