Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Empty filter" type in favor of no filter row #505

Closed
pmeier opened this issue Sep 9, 2024 · 0 comments
Closed

Remove "Empty filter" type in favor of no filter row #505

pmeier opened this issue Sep 9, 2024 · 0 comments
Assignees

Comments

@pmeier
Copy link
Member

pmeier commented Sep 9, 2024

Reported in #499 (comment)


Instead of having an "Empty Filter" type that indicates that we don't want to apply any filter, we should just have no filter row at all.

if self.key_select.value == NO_FILTER_KEY:
return None

image

See #499 (comment) for a non-exhaustive list of problems that we'll have to solve otherwise.

Ultimately, we need to adapt the code such that we don't need the if filter_row.key != NO_FILTER_KEY in

def construct_metadata_filters(self):
metadata_filters = [
filter_row.construct_metadata_filter()
for filter_row in self.filter_rows
if filter_row.key != NO_FILTER_KEY
]
if not metadata_filters:
return None
return MetadataFilter.and_(metadata_filters).to_primitive()

pierrotsmnrd added a commit that referenced this issue Dec 11, 2024
pierrotsmnrd added a commit that referenced this issue Dec 16, 2024
pierrotsmnrd added a commit that referenced this issue Dec 16, 2024
pmeier added a commit that referenced this issue Dec 20, 2024
@pmeier pmeier closed this as completed Dec 20, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Ragna ⛵️ Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants