Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MSRV for clippy in rustworkx #793

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Commits on Jan 26, 2023

  1. Set MSRV for clippy in rustworkx

    Starting in the recently released Rust 1.67.0 clippy enabled a new rule
    by default, uninlined_format_args [1], which warns when format!() is
    used and a variable is not put in the string inline but isntead as a
    separate argument in the macro. For example, `format!("{}", foo)`
    Instead the rule suggests using the variable inline the format call
    (e.g. `format!("{foo}")`. However, with our msrv of 1.56.1
    this syntax was not supported. So trying to fix the places the rule is
    triggered as suggested will fail to compile with rust 1.56.1. To address
    this and solve this for future rust releases and potential new rules this
    commit adds a clippy.toml file which sets the msrv for the rustworkx crate
    This will by default disable rules that weren't on by default in rust
    1.56.1.
    
    [1] https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    mtreinish committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    2526f8b View commit details
    Browse the repository at this point in the history