Set MSRV for clippy in rustworkx #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in the recently released Rust 1.67.0 clippy enabled a new rule
by default, uninlined_format_args [1], which warns when format!() is
used and a variable is not put in the string inline but isntead as a
separate argument in the macro. For example, `format!("{}", foo)`
Instead the rule suggests using the variable inline the format call
(e.g. `format!("{foo}")`. However, with our msrv of 1.56.1
this syntax was not supported. So trying to fix the places the rule is
triggered as suggested will fail to compile with rust 1.56.1. To address
this and solve this for future rust releases and potential new rules this
commit adds a clippy.toml file which sets the msrv for the rustworkx crate
This will by default disable rules that weren't on by default in rust
1.56.1.
[1] https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
IvanIsCoding
approved these changes
Jan 26, 2023
Pull Request Test Coverage Report for Build 4020032791
💛 - Coveralls |
There was a problem hiding this comment.
Also, for future reference: when we upgrade our MSRV, we should delete that file and just use rust-version in Cargo.toml: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field
Both the compiler and Clippy detect that field. I find too many config files a bit confusing.
IvanIsCoding
pushed a commit
that referenced
this pull request
Feb 27, 2023
Starting in the recently released Rust 1.67.0 clippy enabled a new rule
by default, uninlined_format_args [1], which warns when format!() is
used and a variable is not put in the string inline but isntead as a
separate argument in the macro. For example, `format!("{}", foo)`
Instead the rule suggests using the variable inline the format call
(e.g. `format!("{foo}")`. However, with our msrv of 1.56.1
this syntax was not supported. So trying to fix the places the rule is
triggered as suggested will fail to compile with rust 1.56.1. To address
this and solve this for future rust releases and potential new rules this
commit adds a clippy.toml file which sets the msrv for the rustworkx crate
This will by default disable rules that weren't on by default in rust
1.56.1.
[1] https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
mergify bot
added a commit
that referenced
this pull request
Feb 27, 2023
* Fix Matplotlib warning when building docs (#820) Fix the warning in the docs because of matplotlib.cm deprecations. (cherry picked from commit 50c3968) * Fix clippy with Rust 1.66.0 (#762) The recent release of Rust 1.66.0 [1] added new on by default clippy rules which are causing failures when we run the clippy CI job with the new rust version. This commit updates the code to fix the issues that clippy has identified which will unblock CI. [1] https://blog.rust-lang.org/2022/12/15/Rust-1.66.0.html * Set MSRV for clippy in rustworkx (#793) Starting in the recently released Rust 1.67.0 clippy enabled a new rule by default, uninlined_format_args [1], which warns when format!() is used and a variable is not put in the string inline but isntead as a separate argument in the macro. For example, `format!("{}", foo)` Instead the rule suggests using the variable inline the format call (e.g. `format!("{foo}")`. However, with our msrv of 1.56.1 this syntax was not supported. So trying to fix the places the rule is triggered as suggested will fail to compile with rust 1.56.1. To address this and solve this for future rust releases and potential new rules this commit adds a clippy.toml file which sets the msrv for the rustworkx crate This will by default disable rules that weren't on by default in rust 1.56.1. [1] https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args * Pin tox version used in CI to < 4.0.0 (#761) The most recent tox release, 4.0.0, is a major rewrite of the internals of tox and several things behave quite differently. This new release is causing CI jobs to fail as something in incompatible with our tox configuration. This commit pins the tox version we're using in CI to unblock things until we can update the tox configuration to be compatible with both the new and old versions of tox. --------- Co-authored-by: Ivan Carvalho <[email protected]> Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in the recently released Rust 1.67.0 clippy enabled a new rule by default, uninlined_format_args [1], which warns when format!() is used and a variable is not put in the string inline but isntead as a separate argument in the macro. For example,
format!("{}", foo)Instead the rule suggests using the variable inline the format call (e.g.format!("{foo}"). However, with our msrv of 1.56.1 this syntax was not supported. So trying to fix the places the rule is triggered as suggested will fail to compile with rust 1.56.1. To address this and solve this for future rust releases and potential new rules this commit adds a clippy.toml file which sets the msrv for the rustworkx crate This will by default disable rules that weren't on by default in rust 1.56.1.[1] https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args