Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing chevron on previous-next buttons (Cherry-pick of #237) #238

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

This PR adds missing chevron svg file used in footer Previous/Next buttons (original image accidentally removed in #138 ). It also updates references from chevron-right-orange to chevron-right-purple, matching the fill colour used.

Updated footer rendering:

image

Fixes #189

This PR adds missing chevron svg file used in footer Previous/Next
buttons (original image accidentally removed in Qiskit#138 ).
It also updates references from `chevron-right-orange` to
`chevron-right-purple`, matching the fill colour used.

Updated footer rendering:

![image](https://user-images.githubusercontent.com/25207344/228622405-0e8a0ac2-f1b2-44af-be2c-85ee4ac48d52.png)

Fixes Qiskit#189
@Eric-Arellano
Copy link
Collaborator Author

FYI @karlaspuldaro

@Eric-Arellano
Copy link
Collaborator Author

FYI @HuangJunye @javabster this does not run CI because this is on the 1.11 branch. I plan to fix that soon, along with updating the release instructions for how to cherry-pick and how to run a release from a release branch.

Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice catch! LGTM 🚀

@Eric-Arellano Eric-Arellano merged commit 5c28440 into Qiskit:1.11 Mar 30, 2023
@Eric-Arellano Eric-Arellano deleted the cp-chevron-fix branch March 30, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants