Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previous and next button chevron not showing #189

Closed
HuangJunye opened this issue Feb 27, 2023 · 0 comments · Fixed by #237
Closed

previous and next button chevron not showing #189

HuangJunye opened this issue Feb 27, 2023 · 0 comments · Fixed by #237
Labels
bug Something isn't working needs triage Needs further discussion and prioritisation

Comments

@HuangJunye
Copy link
Contributor

Screenshot 2023-02-27 at 14 41 09

#138 removed chevron-right-orange.svg accidentally that are used in the previous and next button:

<div class="rst-footer-buttons" role="navigation" aria-label="footer navigation">
{% if next %}
<a href="{{ next.link|e }}" class="btn btn-neutral float-right" title="{{ next.title|striptags|e }}" accesskey="n" rel="next">{{ _('Next') }} <img src="{{ pathto('_static/images/chevron-right-orange.svg', 1) }}" class="next-page"></a>
{% endif %}
{% if prev %}
<a href="{{ prev.link|e }}" class="btn btn-neutral" title="{{ prev.title|striptags|e }}" accesskey="p" rel="prev"><img src="{{ pathto('_static/images/chevron-right-orange.svg', 1) }}" class="previous-page"> {{ _('Previous') }}</a>
{% endif %}

@HuangJunye HuangJunye added needs triage Needs further discussion and prioritisation bug Something isn't working labels Feb 27, 2023
Eric-Arellano pushed a commit that referenced this issue Mar 29, 2023
This PR adds missing chevron svg file used in footer Previous/Next
buttons (original image accidentally removed in #138 ).
It also updates references from `chevron-right-orange` to
`chevron-right-purple`, matching the fill colour used.

Updated footer rendering:

![image](https://user-images.githubusercontent.com/25207344/228622405-0e8a0ac2-f1b2-44af-be2c-85ee4ac48d52.png)

Fixes #189
Eric-Arellano pushed a commit to Eric-Arellano/qiskit_sphinx_theme that referenced this issue Mar 29, 2023
This PR adds missing chevron svg file used in footer Previous/Next
buttons (original image accidentally removed in Qiskit#138 ).
It also updates references from `chevron-right-orange` to
`chevron-right-purple`, matching the fill colour used.

Updated footer rendering:

![image](https://user-images.githubusercontent.com/25207344/228622405-0e8a0ac2-f1b2-44af-be2c-85ee4ac48d52.png)

Fixes Qiskit#189
Eric-Arellano added a commit that referenced this issue Mar 30, 2023
)

This PR adds missing chevron svg file used in footer Previous/Next
buttons (original image accidentally removed in #138 ). It also updates
references from `chevron-right-orange` to `chevron-right-purple`,
matching the fill colour used.

Updated footer rendering:


![image](https://user-images.githubusercontent.com/25207344/228622405-0e8a0ac2-f1b2-44af-be2c-85ee4ac48d52.png)

Fixes #189

Co-authored-by: Karla Spuldaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Needs further discussion and prioritisation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant