-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loop ops to Aer BackendV2 test #9636
Conversation
789707c (Qiskitgh-9630) added a test for wrapping Aer in a converted `BackendV2` subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the current `main` version (due to soon become version 0.12) because of `break_loop` and `continue_loop` support being added.
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems straightforward enough. Yeah I wrote that test with the current released version of aer on pypi and repeatedly running the test until I had every instruction in the aer simulator's basis gates list.
I just tried to run the test suite locally in an env that has |
Pull Request Test Coverage Report for Build 4243801770
💛 - Coveralls |
789707c (gh-9630) added a test for wrapping Aer in a converted `BackendV2` subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the current `main` version (due to soon become version 0.12) because of `break_loop` and `continue_loop` support being added. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 72a7eac)
789707c (gh-9630) added a test for wrapping Aer in a converted `BackendV2` subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the current `main` version (due to soon become version 0.12) because of `break_loop` and `continue_loop` support being added. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 72a7eac) Co-authored-by: Jake Lishman <[email protected]>
789707c (Qiskitgh-9630) added a test for wrapping Aer in a converted `BackendV2` subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the current `main` version (due to soon become version 0.12) because of `break_loop` and `continue_loop` support being added. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
c785fcb (gh-9630) added a test for wrapping Aer in a converted `BackendV2` subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the current `main` version (due to soon become version 0.12) because of `break_loop` and `continue_loop` support being added. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Summary
789707c (gh-9630) added a test for wrapping Aer in a converted
BackendV2
subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the currentmain
version (due to soon become version 0.12) because ofbreak_loop
andcontinue_loop
support being added.Details and comments