Add loop ops to Aer BackendV2 test #9636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
789707c (Qiskitgh-9630) added a test for wrapping Aer in a converted `BackendV2` subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the current `main` version (due to soon become version 0.12) because of `break_loop` and `continue_loop` support being added.
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
jakelishman
added
the
stable backport potential
mtreinish
approved these changes
Feb 22, 2023
|
I just tried to run the test suite locally in an env that has |
Pull Request Test Coverage Report for Build 4243801770
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
789707c (gh-9630) added a test for wrapping Aer in a converted `BackendV2` subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the current `main` version (due to soon become version 0.12) because of `break_loop` and `continue_loop` support being added. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 72a7eac)
mergify bot
added a commit
that referenced
this pull request
Feb 22, 2023
789707c (gh-9630) added a test for wrapping Aer in a converted `BackendV2` subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the current `main` version (due to soon become version 0.12) because of `break_loop` and `continue_loop` support being added. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 72a7eac) Co-authored-by: Jake Lishman <[email protected]>
Eric-Arellano
pushed a commit
to Eric-Arellano/qiskit-terra
that referenced
this pull request
Feb 23, 2023
789707c (Qiskitgh-9630) added a test for wrapping Aer in a converted `BackendV2` subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the current `main` version (due to soon become version 0.12) because of `break_loop` and `continue_loop` support being added. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-ibm-provider
that referenced
this pull request
Oct 9, 2023
c785fcb (gh-9630) added a test for wrapping Aer in a converted `BackendV2` subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the current `main` version (due to soon become version 0.12) because of `break_loop` and `continue_loop` support being added. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
789707c (gh-9630) added a test for wrapping Aer in a converted
BackendV2subject to providing an extended name mapping for all the custom instructions that Aer supports, which Terra does not generally define. However, the supported lists were based off a slightly older version of Aer (approximately release version 0.11), and fail on the currentmainversion (due to soon become version 0.12) because ofbreak_loopandcontinue_loopsupport being added.Details and comments