Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gate argument from qiskit.transpiler.passes.Decompose #9325

Merged
merged 6 commits into from
Jan 17, 2023

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Dec 26, 2022

Summary

Since #6587, the pass qiskit.transpiler.passes.Decompose raise a deprecation warning when the parameter gate is used. Time to remove it.

Details and comments

The deprecation cycle of this parameter started in 0.19.0 (released in 2021-12-06).

@1ucian0 1ucian0 requested a review from a team as a code owner December 26, 2022 15:06
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@1ucian0 1ucian0 added the Changelog: Removal Include in the Removed section of the changelog label Dec 26, 2022
@coveralls
Copy link

coveralls commented Dec 26, 2022

Pull Request Test Coverage Report for Build 3931962097

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 84.855%

Totals Coverage Status
Change from base Build 3930938890: 0.04%
Covered Lines: 65768
Relevant Lines: 77506

💛 - Coveralls

@jakelishman jakelishman added this to the 0.23.0 milestone Jan 16, 2023
@1ucian0 1ucian0 merged commit 7935003 into Qiskit:main Jan 17, 2023
@1ucian0 1ucian0 deleted the remove/gates_to_decompose branch January 17, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants