QuantumCircuit.decompose() does not take a single gate, but a set of gates to decompose. #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: septembrr <[email protected]>
Cryoris
reviewed
Jul 2, 2021
Cryoris
reviewed
Jul 8, 2021
Cryoris
reviewed
Jul 13, 2021
Cryoris
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #2906 and is an addition to PR #5446. It allows the specification of gates to decompose inside circuit.decompose().
Details and comments
I have changed the variable gates to gates_to_decompose. I have also added fnmatch check to support for * wildcard at the end of the string. I have also added various tests in test_decompose.py.