Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast ParameterExpression to float in RZXBuilder and RZXCalibrationBuilderNoEcho #8965

Merged
merged 8 commits into from
Oct 25, 2022
Merged

Cast ParameterExpression to float in RZXBuilder and RZXCalibrationBuilderNoEcho #8965

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f2a0c46
committing changes but still debugging
nbronn Aug 11, 2022
2863d09
commiting to check necessary changes
nbronn Aug 11, 2022
6c25da9
Merge branch 'main' of github.com:qiskit/qiskit-terra into bug-parame…
nbronn Aug 11, 2022
0113f1c
Merge branch 'main' of github.com:qiskit/qiskit-terra into bug-parame…
nbronn Oct 19, 2022
cb72f3f
added explicit casting to get_calibration in rzx_builder.py in two pl…
nbronn Oct 19, 2022
a57b7de
found a linting error in alap.py
nbronn Oct 20, 2022
357d222
Remove redundant float cast
mtreinish Oct 25, 2022
747e233
Merge branch 'main' into bug-parameter-not-cast
mtreinish Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion qiskit/transpiler/passes/calibration/rzx_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,15 +164,21 @@ def get_calibration(self, node_op: CircuitInst, qubits: List) -> Union[Schedule,
schedule: The calibration schedule for the RZXGate(theta).

Raises:
QiskitError: if rotation angle is not assigned.
QiskitError: If the control and target qubits cannot be identified.
CalibrationNotAvailable: RZX schedule cannot be built for input node.
"""
theta = node_op.params[0]

try:
theta = float(theta)
except TypeError as ex:
raise QiskitError("Target rotation angle is not assigned.") from ex

rzx_theta = Schedule(name="rzx(%.3f)" % theta)
rzx_theta.metadata["publisher"] = CalibrationPublisher.QISKIT

if np.isclose(theta, 0.0):
if np.isclose(float(theta), 0.0):
mtreinish marked this conversation as resolved.
Show resolved Hide resolved
return rzx_theta

cx_sched = self._inst_map.get("cx", qubits=qubits)
Expand Down Expand Up @@ -275,12 +281,18 @@ def get_calibration(self, node_op: CircuitInst, qubits: List) -> Union[Schedule,
schedule: The calibration schedule for the RZXGate(theta).

Raises:
QiskitError: if rotation angle is not assigned.
QiskitError: If the control and target qubits cannot be identified,
or the backend does not natively support the specified direction of the cx.
CalibrationNotAvailable: RZX schedule cannot be built for input node.
"""
theta = node_op.params[0]

try:
theta = float(theta)
except TypeError as ex:
raise QiskitError("Target rotation angle is not assigned.") from ex

rzx_theta = Schedule(name="rzx(%.3f)" % theta)
rzx_theta.metadata["publisher"] = CalibrationPublisher.QISKIT

Expand Down