Cast ParameterExpression to float in RZXBuilder and RZXCalibrationBuilderNoEcho #8965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
mtreinish
added
stable backport potential
Pull Request Test Coverage Report for Build 3323154536
💛 - Coveralls |
mtreinish
reviewed
Oct 20, 2022
mtreinish
approved these changes
Oct 25, 2022
mtreinish
changed the title
mtreinish
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
…lderNoEcho (#8965) * committing changes but still debugging * commiting to check necessary changes * added explicit casting to get_calibration in rzx_builder.py in two places * found a linting error in alap.py * Remove redundant float cast Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit de8e4dd)
mergify bot
added a commit
that referenced
this pull request
Oct 25, 2022
…lderNoEcho (#8965) (#8994) * committing changes but still debugging * commiting to check necessary changes * added explicit casting to get_calibration in rzx_builder.py in two places * found a linting error in alap.py * Remove redundant float cast Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit de8e4dd) Co-authored-by: nick bronn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue 8963.
Details and comments
Explicitly casts
ParameterExpressiontofloatbefore passing tonumpy.isclose()method that requires safe type checking.