Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #9355 deprecate visualize_transition (backport #12287) #12822

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 26, 2024

Fixes #9355

Summary

Addresses #9355 #9355, request to deprecate visualize_transition;
visualize_transition is the sole export of the module qiskit.visualization.transition_visualization,
so the entire module is deprecated as well.

Details and comments

Tentative plan to migrate visualize_transition to somewhere in https://qiskit.org/ecosystem/, probably QuSTaR/kaleidoscope
No tests existed before, no tests added.


This is an automatic backport of pull request #12287 done by Mergify.

* added deprecation warnings and decorators to transition_visualization.py

* fixed style with tox -epy310 -eblack

* added release notes

* added to warning category=DeprecationWarning and stacklevel=2

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <[email protected]>

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <[email protected]>

* Apply suggestions from code review

* Fix lint complaint

---------

Co-authored-by: atharva-satpute <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit 4ec51d1)
@mergify mergify bot requested review from nonhermitian and a team as code owners July 26, 2024 13:13
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

@github-actions github-actions bot added Changelog: Deprecation Include in "Deprecated" section of changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo labels Jul 26, 2024
@github-actions github-actions bot added this to the 1.2.0 milestone Jul 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10111871806

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 89.932%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 3 91.86%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 10111125380: -0.02%
Covered Lines: 66083
Relevant Lines: 73481

💛 - Coveralls

@ElePT ElePT enabled auto-merge July 26, 2024 13:59
@ElePT ElePT added this pull request to the merge queue Jul 26, 2024
Merged via the queue into stable/1.2 with commit c0bd6fd Jul 26, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-12287 branch July 26, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants