Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #9355 deprecate visualize_transition #12287

Merged
merged 10 commits into from
Jul 26, 2024

Conversation

YingHongTham
Copy link
Contributor

@YingHongTham YingHongTham commented Apr 21, 2024

Fixes #9355

Summary

Addresses #9355 #9355, request to deprecate visualize_transition;
visualize_transition is the sole export of the module qiskit.visualization.transition_visualization,
so the entire module is deprecated as well.

Details and comments

Tentative plan to migrate visualize_transition to somewhere in https://qiskit.org/ecosystem/, probably QuSTaR/kaleidoscope
No tests existed before, no tests added.

@YingHongTham YingHongTham requested review from nonhermitian and a team as code owners April 21, 2024 17:56
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Apr 21, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor Author

@YingHongTham YingHongTham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied changes as suggested

@mtreinish mtreinish self-assigned this Jul 25, 2024
@mtreinish mtreinish added this to the 1.2.0 milestone Jul 25, 2024
mtreinish
mtreinish previously approved these changes Jul 25, 2024
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM thanks a ton for doing this. I left a few inline suggestions that I just applied mainly normalizing the deprecation message to be consistent with other deprecations and updated the release note language.

@mtreinish mtreinish enabled auto-merge July 25, 2024 13:54
@mtreinish mtreinish added the Changelog: Deprecation Include in "Deprecated" section of changelog label Jul 25, 2024
@coveralls
Copy link

coveralls commented Jul 25, 2024

Pull Request Test Coverage Report for Build 10110162437

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1723 unchanged lines in 139 files lost coverage.
  • Overall coverage increased (+0.1%) to 89.733%

Files with Coverage Reduction New Missed Lines %
qiskit/qobj/common.py 1 95.83%
qiskit/circuit/library/standard_gates/swap.py 1 98.18%
qiskit/converters/circuit_to_gate.py 1 97.44%
qiskit/circuit/library/standard_gates/r.py 1 97.73%
qiskit/primitives/backend_sampler.py 1 98.86%
qiskit/synthesis/evolution/lie_trotter.py 1 96.77%
qiskit/circuit/library/generalized_gates/permutation.py 1 92.86%
qiskit/circuit/library/standard_gates/rxx.py 1 97.56%
qiskit/circuit/library/standard_gates/u2.py 1 96.88%
qiskit/primitives/base/base_estimator.py 1 97.3%
Totals Coverage Status
Change from base Build 9134495129: 0.1%
Covered Lines: 66689
Relevant Lines: 74319

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtreinish mtreinish added this pull request to the merge queue Jul 26, 2024
@ElePT ElePT added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jul 26, 2024
Merged via the queue into Qiskit:main with commit 4ec51d1 Jul 26, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Jul 26, 2024
* added deprecation warnings and decorators to transition_visualization.py

* fixed style with tox -epy310 -eblack

* added release notes

* added to warning category=DeprecationWarning and stacklevel=2

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <[email protected]>

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <[email protected]>

* Apply suggestions from code review

* Fix lint complaint

---------

Co-authored-by: atharva-satpute <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit 4ec51d1)
github-merge-queue bot pushed a commit that referenced this pull request Jul 26, 2024
* added deprecation warnings and decorators to transition_visualization.py

* fixed style with tox -epy310 -eblack

* added release notes

* added to warning category=DeprecationWarning and stacklevel=2

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <[email protected]>

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <[email protected]>

* Apply suggestions from code review

* Fix lint complaint

---------

Co-authored-by: atharva-satpute <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit 4ec51d1)

Co-authored-by: YingHongTham <[email protected]>
Procatv pushed a commit to Procatv/qiskit-terra-catherines that referenced this pull request Aug 1, 2024
* added deprecation warnings and decorators to transition_visualization.py

* fixed style with tox -epy310 -eblack

* added release notes

* added to warning category=DeprecationWarning and stacklevel=2

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <[email protected]>

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <[email protected]>

* Apply suggestions from code review

* Fix lint complaint

---------

Co-authored-by: atharva-satpute <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Elena Peña Tapia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Deprecate visualize_transition() visualization function
7 participants