Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transpiler docs #12731

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Update transpiler docs #12731

merged 2 commits into from
Jul 8, 2024

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Jul 8, 2024

Summary

Addresses #12706.

Details and comments

@ElePT ElePT requested a review from a team as a code owner July 8, 2024 07:01
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@ElePT ElePT added the documentation Something is not clear or an error documentation label Jul 8, 2024
@coveralls
Copy link

coveralls commented Jul 8, 2024

Pull Request Test Coverage Report for Build 9836300525

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 89.854%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 92.62%
Totals Coverage Status
Change from base Build 9825985118: 0.02%
Covered Lines: 65225
Relevant Lines: 72590

💛 - Coveralls

@jakelishman
Copy link
Member

Whoops, somehow my brain has not woken up this morning and I pressed "update branch" instead of "enable auto-merge".

@jakelishman jakelishman added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Jul 8, 2024
@jakelishman jakelishman added this pull request to the merge queue Jul 8, 2024
Merged via the queue into Qiskit:main with commit 865081e Jul 8, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Jul 8, 2024
Co-authored-by: Jake Lishman <[email protected]>
(cherry picked from commit 865081e)
github-merge-queue bot pushed a commit that referenced this pull request Jul 8, 2024
Co-authored-by: Jake Lishman <[email protected]>
(cherry picked from commit 865081e)

Co-authored-by: Elena Peña Tapia <[email protected]>
Comment on lines +686 to +687
There are other passes than can be used for the heuristic stage, but are not included in the default
pipeline, such as:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this already merged but how does this reconcile with: #12453 which is new in 1.2.0? We're not running the "pass" by default. But we're using the pass internals as part of another one.

Procatv pushed a commit to Procatv/qiskit-terra-catherines that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
5 participants