Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated docs for Transpiler, layout-stage // DensityLayout doesn't default for control flow operations anymore #12706

Closed
GuillermoAbadLopez opened this issue Jul 1, 2024 · 0 comments · Fixed by #12731
Labels
documentation Something is not clear or an error documentation

Comments

@GuillermoAbadLopez
Copy link
Contributor

GuillermoAbadLopez commented Jul 1, 2024

Issue summary:

Outdated documentation for the layout-stage in Transpiler init docs, more concretely, where we talk about DensityLayout being the default Layout when control flow operations are present (with optimizer_level=1).

--

Issue origin:

After a quick discussion in Slack with @mtreinish, I pointed out what was written in the Transpiler documentation, more concretely where it talks about the DenseLayout in the Layout stage section:

"DenseLayout is used for optimization level 1 if there are control flow operations (such as IfElseOp) present in the circuit."

To which Matthew answered:

Oh that's out of date can you open an issue for that so we can update the docs? When control flow was first added in 2022 this was true, but since sabre has been updated to handle control flow too.

--

Links to the relevant documentation:

  :class:`~.DenseLayout`: Finds the sub-graph of the device with greatest connectivity
  that has the same number of qubits as the circuit. Used for
  optimization level 1 if there are control flow operations (such as
  :class:`~.IfElseOp`) present in the circuit.
Screenshot 2024-07-02 at 01 21 08
@GuillermoAbadLopez GuillermoAbadLopez changed the title Outdated documentation for Transpiler, layout-stage // DensityLayout defaults for control flow operations Outdated docs for Transpiler, layout-stage // DensityLayout defaults for control flow operations Jul 1, 2024
@GuillermoAbadLopez GuillermoAbadLopez changed the title Outdated docs for Transpiler, layout-stage // DensityLayout defaults for control flow operations Outdated docs for Transpiler, layout-stage // DensityLayout doesn't default when control flow operations anymore Jul 1, 2024
@GuillermoAbadLopez GuillermoAbadLopez changed the title Outdated docs for Transpiler, layout-stage // DensityLayout doesn't default when control flow operations anymore Outdated docs for Transpiler, layout-stage // DensityLayout doesn't default forcontrol flow operations anymore Jul 1, 2024
@GuillermoAbadLopez GuillermoAbadLopez changed the title Outdated docs for Transpiler, layout-stage // DensityLayout doesn't default forcontrol flow operations anymore Outdated docs for Transpiler, layout-stage // DensityLayout doesn't default for control flow operations anymore Jul 1, 2024
@Eric-Arellano Eric-Arellano added the documentation Something is not clear or an error documentation label Jul 2, 2024
@ElePT ElePT linked a pull request Jul 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something is not clear or an error documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants