Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Qobj input to UnitarySimulatorPy.run #11395

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

rupeshknn
Copy link
Contributor

@rupeshknn rupeshknn commented Dec 11, 2023

Summary

qiskit.providers.basicaer.UnitarySimulatorPy.run() never deprecated a qiskit.qobj.QasmQobj input and will still support it while the qasm simulator and statevector simulator will not.

#11394 deprecates this functionality in a PR to stable/0.46. This PR to main removes this functionality. Fixes #11046

@rupeshknn rupeshknn requested review from jyu00 and a team as code owners December 11, 2023 12:14
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Dec 11, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Dec 11, 2023

Pull Request Test Coverage Report for Build 7168022336

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 87.556%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/providers/basicaer/unitary_simulator.py 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 92.17%
crates/accelerate/src/quantum_circuit/circuit_data.rs 8 90.71%
Totals Coverage Status
Change from base Build 7163309461: 0.002%
Covered Lines: 59771
Relevant Lines: 68266

💛 - Coveralls

@ElePT ElePT added the Changelog: Removal Include in the Removed section of the changelog label Dec 18, 2023
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for your contribution.

@ElePT ElePT added this pull request to the merge queue Dec 18, 2023
Merged via the queue into Qiskit:main with commit 74661de Dec 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Deprecate Qobj in unitary_simulator.py
4 participants