Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Qobj input to UnitarySimulatorPy.run #11394

Merged
merged 7 commits into from
Dec 18, 2023

Conversation

rupeshknn
Copy link
Contributor

@rupeshknn rupeshknn commented Dec 11, 2023

Summary

qiskit.providers.basicaer.UnitarySimulatorPy.run() never deprecated a qiskit.qobj.QasmQobj input and will still support it while the qasm simulator and statevector simulator will not. This PR to stable/0.46 deprecates this functionality, and #11395 to main removes it.

Fixes #11046

Based on the conversation here with @1ucian0 I'll start with a deprecation PR to stable/0.46 and once that's done, I'll do a removal PR to main.

@rupeshknn rupeshknn requested review from jyu00 and a team as code owners December 11, 2023 11:36
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Dec 11, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@rupeshknn
Copy link
Contributor Author

rupeshknn commented Dec 18, 2023

@1ucian0 This PR has been ready for review. can you review this?

@ElePT ElePT added the Changelog: Deprecation Include in "Deprecated" section of changelog label Dec 18, 2023
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is a very well done deprecation, thanks a lot for the attention to detail. My only comment is that we don't generally document API docs changes in our changelog, so there is no need for the fixes section of the reno.

@ElePT ElePT added this to the 0.46.0 milestone Dec 18, 2023
Co-authored-by: Elena Peña Tapia <[email protected]>
@ElePT ElePT enabled auto-merge December 18, 2023 15:42
@ElePT ElePT added this pull request to the merge queue Dec 18, 2023
Merged via the queue into Qiskit:stable/0.46 with commit 3d69927 Dec 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants