-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Qobj input to UnitarySimulatorPy.run
#11394
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
@1ucian0 This PR has been ready for review. can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is a very well done deprecation, thanks a lot for the attention to detail. My only comment is that we don't generally document API docs changes in our changelog, so there is no need for the fixes
section of the reno.
releasenotes/notes/deprecate-qobj-input-in-UnitarySimulatorPy-7233ec171fa15bd8.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Elena Peña Tapia <[email protected]>
Summary
qiskit.providers.basicaer.UnitarySimulatorPy.run()
never deprecated aqiskit.qobj.QasmQobj
input and will still support it while the qasm simulator and statevector simulator will not. This PR tostable/0.46
deprecates this functionality, and #11395 tomain
removes it.Fixes #11046