Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deprecated PauliTable, StabilizerTable and tests #10815

Merged
merged 9 commits into from
Oct 17, 2023

Conversation

adigaboy
Copy link
Contributor

Summary

Removed Deprecated code:
PauliTable
StabilizerTable
deprecated functions
and tests

Details and comments

@adigaboy adigaboy requested review from ikkoham and a team as code owners September 11, 2023 20:21
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Sep 11, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ikkoham

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Raghav-Bell
Copy link
Contributor

Raghav-Bell commented Sep 12, 2023

@adigaboy Please check lint tests locally (refer to contribution guide) and add release note. Also remove tests from test_pauli_sum_op.py. As of now (latest), 0.22 deprecated code removal is requested (issue #10810 ). I don't think maintainers are going to remove deprecated code for 0.24 soon , let us wait for the review from maintainers.

@ikkoham ikkoham added this to the 0.45.0 milestone Oct 2, 2023
@ikkoham ikkoham self-assigned this Oct 2, 2023
@ikkoham
Copy link
Contributor

ikkoham commented Oct 2, 2023

@adigaboy Thank you very much. This is really important PR. Could you resolve the conflicts?

@ikkoham ikkoham added Changelog: Removal Include in the Removed section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) labels Oct 2, 2023
Copy link
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR requires a release note for removal.

ikkoham
ikkoham previously approved these changes Oct 16, 2023
Copy link
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, and thanks Hamamura-san for the reviewing and helping to fix up the last bits. I just had one super minor comment about the release note, but otherwise let's get this merged.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6540287880

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.008%) to 87.063%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 91.16%
qiskit/extensions/quantum_initializer/squ.py 2 84.15%
crates/qasm2/src/parse.rs 6 97.6%
Totals Coverage Status
Change from base Build 6539695207: -0.008%
Covered Lines: 74015
Relevant Lines: 85013

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Oct 17, 2023
Merged via the queue into Qiskit:main with commit 6246783 Oct 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo mod: quantum info Related to the Quantum Info module (States & Operators)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants