-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed deprecated PauliTable, StabilizerTable and tests #10815
removed deprecated PauliTable, StabilizerTable and tests #10815
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
|
@adigaboy Please check lint tests locally (refer to contribution guide) and add release note. Also remove tests from |
@adigaboy Thank you very much. This is really important PR. Could you resolve the conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR requires a release note for removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, and thanks Hamamura-san for the reviewing and helping to fix up the last bits. I just had one super minor comment about the release note, but otherwise let's get this merged.
releasenotes/notes/remove-deprecated-in-quantum-info-0f9bd2b0c093307d.yaml
Outdated
Show resolved
Hide resolved
…093307d.yaml Co-authored-by: Jake Lishman <[email protected]>
Pull Request Test Coverage Report for Build 6540287880
💛 - Coveralls |
Summary
Removed Deprecated code:
PauliTable
StabilizerTable
deprecated functions
and tests
Details and comments