-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove code deprecated in 0.22 (released on October 13, 2022) [pulse] #10810
Comments
Please assign this issue to me. |
Hi @Raghav-Bell , thanks for volunteer! If you don't mind, let's first close some of the open PRs and we can leave |
Yes @1ucian0 I agree. |
If this issue still needs attention...Can I be assigned to this? I am new comer.. I wanna try this out. Thank you |
I am also interested in contributing as a newcomer, please let me know if this task can be assigned to me |
@Ak-ash22, assigning you! Thanks! |
Hello @1ucian0 ...This is my first time contributing.. kindly help me verify if this is correct : |
The line numbers in the original post might be out of date. I removed |
@1ucian0 I noticed that all the classes in the parametric_pulses.py have been deprecated, so I decided to delete the entire file. Also I noticed a bug in the related test.... in the qiskit/test/python/pulse/test_pulse_lib.py, there is a test class named TestParametricPulses but it calls all the Gaussian, Constant etc waveforms from the symbolic_pulses.py and not from the paramteric_pulses.py. So I changed the name of the test class to TestSymbolicPulses(..). Also I made sure that there is no test case for symbolic pulses, just to be sure I am not duplicating it. |
There is code released 9 month ago that needs to be removed.
qiskit/pulse/utils.py:113
qiskit/pulse/library/parametric_pulses.py:66
qiskit/pulse/library/parametric_pulses.py:135
qiskit/pulse/library/parametric_pulses.py:247
qiskit/pulse/library/parametric_pulses.py:417
qiskit/pulse/library/parametric_pulses.py:540
This includes:
Changelog: Removal
upgrade:
. If you can include an example with an alternative for user to migrate to the new code, as this change might break users code.Related:
The text was updated successfully, but these errors were encountered: