-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests #128
Merged
Merged
Refactor tests #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y4izus
force-pushed
the
yg-refactor-tests
branch
from
November 20, 2024 11:23
9b04d63
to
ca7617c
Compare
y4izus
requested review from
cbjuan,
d-kremer and
victor-villar
as code owners
November 20, 2024 12:02
victor-villar
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I thin we need to fix the circuits, either by setting the seed in all random generation steps or by creating/passing fixed circuits. Otherwise the pipeline will fail randomly.
We can fix other todos later.
This was referenced Nov 28, 2024
jesus-talavera-ibm
approved these changes
Dec 3, 2024
victor-villar
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details and comments
Done in this PR:
skip
for that caseMore posible refactor where I would like to hear your thoughts:
Thanks!