Pin aiohttp != 3.9.0 during notebook tests
#454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the notebook tests (and CI). See discussion at #453.
Pull Request Test Coverage Report for Build 6933050306
💛 - Coveralls |
|
I merged this to get CI to turn green again. Let's plan to unpin it whenever we can. |
garrison
added a commit
that referenced
this pull request
Nov 20, 2023
In #454, I pinned `aiohttp`, but the failure was actually due to `async-timeout` not being installed (#453 (comment)). This PR updates `pyproject.toml` in accordance with this root cause. We can remove this line once a version of ray is released that fixes ray-project/ray#41267.
garrison
added a commit
that referenced
this pull request
Nov 20, 2023
In #454, I pinned `aiohttp`, but the failure was actually due to `async-timeout` not being installed (#453 (comment)). This PR updates `pyproject.toml` in accordance with this root cause. We can remove this line once a version of ray is released that fixes ray-project/ray#41267.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the notebook tests (and CI). See discussion at #453.