-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cutting with quantum serverless notebook fails with aiohttp == 3.9.0
#453
Comments
This fixes the notebook tests (and CI). See discussion at #453.
This fixes the notebook tests (and CI). See discussion at #453.
This seems like an issue with an upstream dependency. Once this is resolved upstream, let's be sure to |
Actually, I think I figured out that the "real" problem here. It's that I made a comment at ray-project/ray#41267 (comment). |
In #454, I pinned `aiohttp`, but the failure was actually due to `async-timeout` not being installed (#453 (comment)). This PR updates `pyproject.toml` in accordance with this root cause. We can remove this line once a version of ray is released that fixes ray-project/ray#41267.
In #454, I pinned `aiohttp`, but the failure was actually due to `async-timeout` not being installed (#453 (comment)). This PR updates `pyproject.toml` in accordance with this root cause. We can remove this line once a version of ray is released that fixes ray-project/ray#41267.
This will need to wait until Ray 2.9.0 is released, following ray-project/ray#41267 (comment). Fixes #453.
This will need to wait until Ray 2.9.0 is released, following ray-project/ray#41267 (comment). Fixes #453.
aiohttp 3.9.0 was released a few days ago, and since then CI has been failing because the "notebook" tests fail. I haven't gotten to the bottom of why they fail, but I have confirmed that a pin fixes things:
Here's the "full" error:
If we can't get to the bottom of this very soon, we should merge the pin for the time being.
The text was updated successfully, but these errors were encountered: