Updates to Grover's Algorithm chapter #185
Conversation
|
|
|
@SaraM92 thank you!! if possible, can you sign the contributor agreement? see comment above for link. i have created a draft PR of the update. we also have a preview deployed here for (the team to review and comment): @frankharkins any feedback is appreciated. thanks! |
|
Yes indeed. I'll make a design issue in the backlog, but that shouldn't be a blocker for this PR. |
@JRussellHuffman cool. just wanted to get it into your radar. thanks!! |
There was a problem hiding this comment.
This is awesome thank you @SaraM92. I really like the triangle finding problem example you've added. I think it's a neat example and I like that it shows a different state preparation circuit.
The only big thing I'd change would be changing the formatting of the code examples a bit to match qiskit's style. If you want to use the linter, you can add this notebook's filepath to scripts/notebook_paths.txt. The textbook linter is a still a work-in-progress so let me know if it's giving you problems and we can change some of the rules.
Other than that, I added some other minor comments as I read through.
notebooks/ch-algorithms/grover.ipynb
Outdated
| "\n", | ||
| "The first step of Grover's algorithm is the initial state preparation. As we just mentioned, the search space is all possible values we need to search through to find the answer we want. For the examples in this textbook, our 'database' is comprised of all the possible computational basis states our qubits can be in. For example, if we have 3 qubits, our list is the states $|000\\rangle, |001\\rangle, \\dots |111\\rangle$ (i.e the states $|0\\rangle \\rightarrow |7\\rangle$). So, in this case the size of our search space will be $N = 2^{3} = 8$.\n", | ||
| "\n", | ||
| "**Maybe add a page about the Dicke state in the composer circuit examples??**\n", |
There was a problem hiding this comment.
| "**Maybe add a page about the Dicke state in the composer circuit examples??**\n", |
We don't have control over the composer docs, we can request they consider this but for now we can link to wikipedia (or another resource) in the annotation
notebooks/ch-algorithms/grover.ipynb
Outdated
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "def cnz(qc, num_control, node, anc):\n", |
There was a problem hiding this comment.
Can you use something from the circuit library here instead of building yourself please? The MCPhaseGate is closest I can find.
There was a problem hiding this comment.
The new graphics will need to be restyled to match the textbook aesthetic, which a new issue has been opened for that here. Otherwise, they look good to me.
|
@frankharkins i believe all your comments have been addressed. any final thoughts or are you good with merging this? |
vabarbosa
requested review from
abdonrd,
korgan00 and
Tansito
as code owners
preview URL:
related: qiskit-advocate/qamp-fall-21#21