Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update CHANGELOG.md with merged pull request #2164 #2220

Merged
merged 2 commits into from
Aug 31, 2023
Merged

docs: Update CHANGELOG.md with merged pull request #2164 #2220

merged 2 commits into from
Aug 31, 2023

Conversation

CarrotManMatt
Copy link
Contributor

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@CarrotManMatt
Update CHANGELOG.md
766b28d 
Signed-off-by: CarrotManMatt <[email protected]>
@CarrotManMatt CarrotManMatt requested a review from a team as a code owner August 31, 2023 21:10
@pullapprove4 pullapprove4 bot requested a review from ChickenDevs August 31, 2023 21:10
@pullapprove4 pullapprove4 bot requested a review from VincentRPS August 31, 2023 21:10
@CarrotManMatt CarrotManMatt changed the title Update CHANGELOG.md with merged pull request #2164 docs: Update CHANGELOG.md with merged pull request #2164 Aug 31, 2023
@JustaSqu1d JustaSqu1d self-requested a review August 31, 2023 21:19
@Lulalaby Lulalaby enabled auto-merge (squash) August 31, 2023 21:20
@JustaSqu1d
Copy link
Member

Actually, I think type-hinting changes are not supposed to be changelog'ed. Confirmation?

@Lulalaby Lulalaby merged commit 2256710 into Pycord-Development:master Aug 31, 2023
@CarrotManMatt
Copy link
Contributor Author

Actually, I think type-hinting changes are not supposed to be changelog'ed. Confirmation?

Oh, I only added it because i saw #2148 was added to the changelog.

@CarrotManMatt CarrotManMatt deleted the patch-1 branch August 31, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@ChickenDevs ChickenDevs Awaiting requested review from ChickenDevs

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarrotManMatt @JustaSqu1d @Lulalaby