fix: properly type ApplicationContext.author

[Yuki-42]

Updated author property of ApplicationContext to include typehinting for applicable types.

Summary

This change is intended to assist IDEs like pyCharm in both creating applicable warnings and code completion. This is done to fix The reason that I am trying to add typehinting is without it pycharm kinda just doesn't recognize that the author is an instance of Member or User and throws all kinds of errors when I add proper documentation.

Documentation example:
"""
The trade command for the bot. Allows users to trade with other users.

Args:
    ctx (ApplicationContext): The context of the command
    user (User): The user to trade with
    item (int): The item to trade
    amount (int): The amount of the item to trade
    cost (int): The payment for the trade
"""

Without this change pycharm does not recognize that the author is an instance of Member or User.

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.

[plun1331]

Please add a changelog entry

[codecov]

Codecov Report

Merging #2148 (675edc3) into master (297053d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2148   +/-   ##
=======================================
  Coverage   33.86%   33.86%           
=======================================
  Files         109      109           
  Lines       22367    22367           
=======================================
  Hits         7575     7575           
  Misses      14792    14792           

Flag	Coverage Δ
macos-latest-3.10	33.84% <100.00%> (ø)
macos-latest-3.11	33.84% <100.00%> (ø)
macos-latest-3.8	33.85% <100.00%> (ø)
macos-latest-3.9	33.85% <100.00%> (ø)
ubuntu-latest-3.10	33.84% <100.00%> (ø)
ubuntu-latest-3.11	33.84% <100.00%> (ø)
ubuntu-latest-3.8	33.85% <100.00%> (ø)
ubuntu-latest-3.9	33.85% <100.00%> (ø)
windows-latest-3.10	33.84% <100.00%> (ø)
windows-latest-3.11	33.84% <100.00%> (ø)
windows-latest-3.8	33.85% <100.00%> (ø)
windows-latest-3.9	33.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
discord/commands/context.py	50.34% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297053d...675edc3. Read the comment docs.

[Yuki-42]

Please add a changelog entry

Would it go in added, changed, or fixed?

[plun1331]

Please add a changelog entry

Would it go in added, changed, or fixed?

I would say fixed since it's fixing bad typing, possibly added since there was no typehint to begin with

[JustaSqu1d]

Please add a changelog entry

Would it go in added, changed, or fixed?

I would say fixed since it's fixing bad typing, possibly added since there was no typehint to begin with

In my opinion, it makes the most sense for "fixed," as well.

[Yuki-42]

I'm assuming something along the lines of

• Fixed type-hinting of author property of ApplicationContext to include typehinting of User or Member.
  (#2148)

would be fine?

[Lulalaby]

Yes perfectly fine

[Yuki-42]

I believe I have added the changelog entry correctly.

x