Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add #[inline] hints on many Bound and Borrowed methods #4024

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

davidhewitt
Copy link
Member

When looking at the codspeed benchmark for #4016 I noticed that we were missing #[inline] on many basic operations on Bound and Borrowed which probably make sense to be #[inline].

Let's see if this reports any meaningful improvements...

Copy link

codspeed-hq bot commented Mar 30, 2024

CodSpeed Performance Report

Merging #4024 will improve performances by 24.24%

Comparing davidhewitt:inline-borrowed (34764a3) with main (74d9d23)

Summary

⚡ 1 improvements
✅ 67 untouched benchmarks

Benchmarks breakdown

Benchmark main davidhewitt:inline-borrowed Change
drop_many_objects 68.6 µs 55.2 µs +24.24%

@davidhewitt
Copy link
Member Author

Seems like this does help a little, so let's proceed 😁

@davidhewitt davidhewitt marked this pull request as ready for review March 30, 2024 22:10
@davidhewitt davidhewitt added this pull request to the merge queue Mar 30, 2024
Merged via the queue into PyO3:main with commit 9d932c1 Mar 30, 2024
43 checks passed
@davidhewitt davidhewitt deleted the inline-borrowed branch March 30, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants