Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmark for class / method calls #4016

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

davidhewitt
Copy link
Member

As a first step for #3843, let's add some benchmarks.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Mar 29, 2024
Copy link

codspeed-hq bot commented Mar 29, 2024

CodSpeed Performance Report

Merging #4016 will improve performances by 10.78%

Comparing davidhewitt:methods-benchmark (936851f) with main (74d9d23)

Summary

⚡ 1 improvements
✅ 67 untouched benchmarks

🆕 4 new benchmarks

Benchmarks breakdown

Benchmark main davidhewitt:methods-benchmark Change
🆕 test_method_call N/A 19.6 µs N/A
🆕 test_method_call_py N/A 19.7 µs N/A
🆕 test_proto_call N/A 18.7 µs N/A
🆕 test_proto_call_py N/A 19.8 µs N/A
test_simple_py 28.9 µs 26 µs +10.78%

@davidhewitt
Copy link
Member Author

Now that I think about this more, probably the meaningful benchmark is to measure calling from Python. I'll move this to pytests later.

@davidhewitt davidhewitt marked this pull request as draft March 29, 2024 16:32
@davidhewitt davidhewitt marked this pull request as ready for review March 30, 2024 20:28
@davidhewitt
Copy link
Member Author

As a small benchmark addition, I will just proceed to merge. I'd like to push a PR which uses this benchmark; having this in means codspeed will report if the PR actually makes a difference 👀

@davidhewitt davidhewitt added this pull request to the merge queue Mar 30, 2024
Merged via the queue into PyO3:main with commit 22e8dd1 Mar 30, 2024
43 checks passed
@davidhewitt davidhewitt deleted the methods-benchmark branch March 30, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant