Properly handle dynamic version in pyproject.toml #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
37 tasks
7 tasks
warthog9
added a commit
to warthog9/luwen
that referenced
this pull request
Dec 30, 2024
Maturin made a change to come inline more specifically with pyproject.toml spec, unfortunately it's not a "backwards compatible" change and was done with little fanfare or warning, and immediately caused breakage outside distro's more plodding versions. Maturin Issue: PyO3/maturin#2390 pyproject.toml spec: https://packaging.python.org/en/latest/specifications/pyproject-toml/#dynamic change in Maturin committed here: PyO3/maturin#2391 This commit superceeds the luwen PR here: tenstorrent#11 as that sets an explicit version, and we don't want that as it adds more sources of truth on the version (seriously there should be 1, and only 1). Signed-off-by: John 'Warthog9' Hawley <[email protected]>
This was referenced Dec 30, 2024
warthog9
added a commit
to warthog9/luwen
that referenced
this pull request
Dec 30, 2024
Maturin made a change to come inline more specifically with pyproject.toml spec, unfortunately it's not a "backwards compatible" change and was done with little fanfare or warning, and immediately caused breakage outside distro's more plodding versions. Maturin Issue: PyO3/maturin#2390 pyproject.toml spec: https://packaging.python.org/en/latest/specifications/pyproject-toml/#dynamic change in Maturin committed here: PyO3/maturin#2391 This commit superceeds the luwen PR here: tenstorrent#11 as that sets an explicit version, and we don't want that as it adds more sources of truth on the version (seriously there should be 1, and only 1). Reported-by: Dongjin Na <[email protected]> Signed-off-by: John 'Warthog9' Hawley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2390