Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Maturin 1.8: add a version key in the project metadata #64

Closed

Conversation

agriyakhetarpal
Copy link

@agriyakhetarpal agriyakhetarpal commented Dec 30, 2024

Description

Through PyO3/maturin#2391 via the recently released https://github.com/PyO3/maturin/releases/tag/v1.8.0, we've been seeing failing builds for PyXIRR in Pyodide (logs), which was added in pyodide/pyodide#4513.

I've opened this PR since I saw that you were listed as a maintainer for PyXIRR's recipe in Pyodide, and I shall be applying this PR as a patch to fix the failing build. If you'd like me to set it as a dynamic attribute or something else of your liking, please let me know. Thank you!

Additional context

@agriyakhetarpal agriyakhetarpal changed the title Add a version key in [project] table Updates for Maturin 1.8: add a version key in the project metadata Dec 30, 2024
@agriyakhetarpal
Copy link
Author

I don't think any other changes should be required here; triggering https://github.com/Anexen/pyxirr/actions/runs/12546123566 would be helpful and I could take a look if there are any failures.

@Anexen
Copy link
Owner

Anexen commented Jan 2, 2025

Closing this because I've added dynamic = ["version"] to the project section since maturin is automatically pulling the version from Cargo.toml.

@Anexen Anexen closed this Jan 2, 2025
@agriyakhetarpal
Copy link
Author

Thanks! That should work, too. :)

@agriyakhetarpal agriyakhetarpal deleted the fix/maturin-1.8-updates branch January 2, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants