Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS m1 Runner & move target aarch64 to this runner #2001

Merged

Conversation

Owen-CH-Leung
Copy link
Contributor

fixes #1952

This PR enhances the generate-ci command for github actions. Specifically, it addes a new CI job to be running on macos m1 runner, and move away cross compilation to aarch64 from the original mac runner.

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 152437e
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/65fbe026466fec0008dc0727
😎 Deploy Preview https://deploy-preview-2001--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/ci.rs Outdated Show resolved Hide resolved
@Owen-CH-Leung Owen-CH-Leung marked this pull request as ready for review March 21, 2024 07:52
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I might tweak it a bit later to merge macos arm64 with macos using a different matrix like:

matrix:
  platform:
    - os: macos-latest
      target: x86_64
    - os: macos-14
      target: aarch64

Feel free take this refactoring task if you want to.

@messense messense merged commit ef99753 into PyO3:main Mar 21, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use macOS M1 runner in generated GitHub Actions configuration
2 participants