Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macOS M1 runner in generated GitHub Actions configuration #1952

Closed
messense opened this issue Feb 21, 2024 · 0 comments · Fixed by #2001
Closed

Use macOS M1 runner in generated GitHub Actions configuration #1952

messense opened this issue Feb 21, 2024 · 0 comments · Fixed by #2001
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers

Comments

@messense
Copy link
Member

No need to cross compiling to macOS arm64 on x86_64 now that GitHub Actions has macOS M1 runners (macos-14).

maturin/src/ci.rs

Lines 213 to 222 in b209c4b

let plat_name = platform.to_string();
let os_name = match platform {
Platform::Linux | Platform::Emscripten => "ubuntu",
_ => &plat_name,
};
needs.push(platform.to_string());
conf.push_str(&format!(
" {plat_name}:
runs-on: {os_name}-latest\n"
));

@messense messense added enhancement New feature or request good first issue Good for newcomers github_actions Pull requests that update GitHub Actions code labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant