Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify SaveOptions in server capabilities #320

Merged
merged 1 commit into from
Jun 2, 2023

Commits on Jun 2, 2023

  1. Specify SaveOptions in server capabilities

    `textDocument/didSave` is specified by the server capability of
    SaveOptions or bool in the TextDocumentSyncOptions. Since this wasn't
    getting set, some clients may not send `textDocument/didSave` since the
    server never broadcasted this capability.
    
    `includeText` is set to `false` since I didn't see anywhere we use the
    text contents when responding to this method.
    
    I've confirmed this fixes a bug in the client `helix` as dub build lints
    weren't getting triggered since it wouldn't send the
    `textDocument/didSave` message unless this capability was sent.
    tarkah committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    e5b2598 View commit details
    Browse the repository at this point in the history