Specify SaveOptions in server capabilities #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`textDocument/didSave` is specified by the server capability of SaveOptions or bool in the TextDocumentSyncOptions. Since this wasn't getting set, some clients may not send `textDocument/didSave` since the server never broadcasted this capability. `includeText` is set to `false` since I didn't see anywhere we use the text contents when responding to this method. I've confirmed this fixes a bug in the client `helix` as dub build lints weren't getting triggered since it wouldn't send the `textDocument/didSave` message unless this capability was sent.
WebFreak001
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
thanks! Yeah I had a special config with code-d & serve-d before the LSP options were able to ask the client for file watching like this, so I never upgraded this part of the code.
If content sync becomes a problem on saving, might want to include the text in the future and submit it to the text document manager, although I think that won't be necessary.
|
my bad on the test case failures, although I'm not sure why it's trying to download new versions when I include a dub.selections.json. Will investigate in master |
rtbo
added a commit
to rtbo/serve-d
that referenced
this pull request
Jun 6, 2023
textDocument/didOpen was not sent anymore by VS code since Pure-D#320
WebFreak001
pushed a commit
that referenced
this pull request
Jun 8, 2023
textDocument/didOpen was not sent anymore by VS code since #320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
textDocument/didSaveis specified by the server capability of SaveOptions or bool in the TextDocumentSyncOptions. Since this wasn't getting set, some clients may not sendtextDocument/didSavesince the server never broadcasted this capability.includeTextis set tofalsesince I didn't see anywhere we use the text contents when responding to this method.I've confirmed this fixes a bug in the client
helixas dub build lints weren't getting triggered since it wouldn't send thetextDocument/didSavemessage unless this capability was sent.Relevant docs: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_didSave
Related issue on Helix side: helix-editor/helix#3957