-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration release #253
Integration release #253
Conversation
Issues preventing build from succeeding:
|
We have a possible fix, but now (possibly due to a library change) I am confronted with another error in my local tests:
Update - this was due to configuration issue, a warning for which has now been added. |
The API tests are failing due to an issue in https://github.com/ProxeusApp/node-crypto-forex-rates |
I have tried to disable the areas of CI that are failing - for me without clearly identifiable cause - in the latest commit. Adding warnings in the log (via |
newKeys = append(newKeys, *a) | ||
err := tx.Set(userApiKeyBucket, a.Key, u.ID) | ||
if err != nil { | ||
return err | ||
} | ||
a.HideKey() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should remain the logic with hide key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quickly tested and this line breaks the process. It is not needed to hash the key again at this point, as far as I can tell.
This PR currently contains patches from #244 with additional library upgrades.