Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration release #253

Merged
merged 18 commits into from
Apr 7, 2022
Merged

Integration release #253

merged 18 commits into from
Apr 7, 2022

Conversation

loleg
Copy link
Contributor

@loleg loleg commented Feb 17, 2022

This PR currently contains patches from #244 with additional library upgrades.

@loleg
Copy link
Contributor Author

loleg commented Mar 24, 2022

Issues preventing build from succeeding:

--- FAIL: TestUser (4.26s)
    user_test.go:64: 
        Unexpected non-nil/non-zero argument at index 1:
        	<*errors.errorString>: &errors.errorString{s:"authority missing"}
FAIL
FAIL	github.com/ProxeusApp/proxeus-core/storage/database	4.300s

@loleg
Copy link
Contributor Author

loleg commented Mar 31, 2022

We have a possible fix, but now (possibly due to a library change) I am confronted with another error in my local tests:

ERROR: crypto/aes: invalid key size 26
goroutine 1 [running]:
runtime/debug.Stack(0x27, 0x0, 0x0)
	/usr/lib/golang/src/runtime/debug/stack.go:24 +0x9f
runtime/debug.PrintStack()
	/usr/lib/golang/src/runtime/debug/stack.go:16 +0x25
github.com/ProxeusApp/proxeus-core/storage/database.TestMain.func2(0x103f960, 0x1540070)
	/home/oleg/Localdev/Proxeus/proxeus-core/storage/database/common_test.go:62 +0xd9
github.com/ProxeusApp/proxeus-core/storage/database.TestMain(0xc0002fe100)
	/home/oleg/Localdev/Proxeus/proxeus-core/storage/database/common_test.go:70 +0x27d
main.main()
	_testmain.go:63 +0x165
FAIL	github.com/ProxeusApp/proxeus-core/storage/database	0.011s

Update - this was due to configuration issue, a warning for which has now been added.

@loleg loleg requested a review from a team April 4, 2022 22:26
@loleg
Copy link
Contributor Author

loleg commented Apr 4, 2022

The API tests are failing due to an issue in https://github.com/ProxeusApp/node-crypto-forex-rates
I suggest closing this PR so we can get a fresh version up in master and continue looking into it with a fresh branch.

@loleg
Copy link
Contributor Author

loleg commented Apr 5, 2022

I have tried to disable the areas of CI that are failing - for me without clearly identifiable cause - in the latest commit. Adding warnings in the log (via Makefile) that we need to put in more work here. And starting a branch where I'm trying to fix or at least better understand the issue: https://github.com/loleg/proxeus-core/tree/api-debugging

newKeys = append(newKeys, *a)
err := tx.Set(userApiKeyBucket, a.Key, u.ID)
if err != nil {
return err
}
a.HideKey()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remain the logic with hide key

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly tested and this line breaks the process. It is not needed to hash the key again at this point, as far as I can tell.

@VivienFuhrer VivienFuhrer merged commit 61b19c5 into ProxeusApp:master Apr 7, 2022
@loleg loleg deleted the javany-244 branch April 7, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants