Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash User API Keys. #244

Closed
wants to merge 3 commits into from
Closed

hash User API Keys. #244

wants to merge 3 commits into from

Conversation

m-javani
Copy link
Contributor

Hashing user API keys

This pull request is to store the hashed version of User API Keys.

Description

This pull request deals with issue #242 and applies the following changes:

  • User API keys are hashed before being inserted into the database.
  • UI no more shows the keys. Users still can delete the keys by key name

@loleg
Copy link
Contributor

loleg commented Feb 17, 2022

Test failing with error:

--- FAIL: TestUser (4.75s)
    user_test.go:64: 
        Unexpected non-nil/non-zero argument at index 1:
        	<*errors.errorString>: &errors.errorString{s:"authority missing"}
FAIL
FAIL	github.com/ProxeusApp/proxeus-core/storage/database

I am going to close this and re-open after doing the fix in another branch.

@loleg loleg closed this Feb 17, 2022
@loleg loleg mentioned this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants