-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contract): add javascript validation #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chuck-D-Norris
requested review from
Ism1tha,
0x1026,
SandraFerrando,
oriolreverte36 and
XavierChao
November 28, 2024 14:38
github-actions
bot
added
the
area/app/views
Categorizes issue or PR as related to app/views.
label
Nov 28, 2024
SandraFerrando
approved these changes
Nov 28, 2024
Signed-off-by: Hugoo <[email protected]>
0x1026
changed the title
feat (contract): Validation Contracts
feat(contract): add javascript validation
Nov 29, 2024
0x1026
added
lifecycle/active
Indicates that an issue or PR is actively being worked on by a contributor.
milestone/current
Indicates an issue or PR that is being worked on at the current milestone.
labels
Nov 30, 2024
0x1026
force-pushed
the
main
branch
2 times, most recently
from
December 2, 2024 21:12
f43896f
to
a6dd618
Compare
0x1026
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aquest PR no s'ha provat pel propi autor. Revisa les modificacions :)
github-actions
bot
added
area/database
Categorizes issue or PR as related to database.
area/app/models
Categorizes issue or PR as related to app/models.
labels
Dec 3, 2024
github-actions
bot
added
kind/feature
Categorizes issue or PR as related to a new feature.
and removed
area/database
Categorizes issue or PR as related to database.
area/app/models
Categorizes issue or PR as related to app/models.
area/app/controllers
Categorizes issue or PR as related to app/controllers.
area/routes
Categorizes issue or PR as related to routes or router.
labels
Dec 4, 2024
0x1026
force-pushed
the
main
branch
2 times, most recently
from
December 4, 2024 14:07
bc61500
to
50315fc
Compare
0x1026
force-pushed
the
main
branch
5 times, most recently
from
December 5, 2024 04:52
4a53d39
to
332647b
Compare
github-actions
bot
added
the
area/database
Categorizes issue or PR as related to database.
label
Dec 10, 2024
0x1026
force-pushed
the
feat/contract
branch
from
December 10, 2024 09:14
e6113a7
to
14d83e2
Compare
github-actions
bot
added
the
area/javascript
Categorizes issue or PR as related to JavaScript.
label
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/app/views
Categorizes issue or PR as related to app/views.
area/database
Categorizes issue or PR as related to database.
area/javascript
Categorizes issue or PR as related to JavaScript.
kind/feature
Categorizes issue or PR as related to a new feature.
lifecycle/active
Indicates that an issue or PR is actively being worked on by a contributor.
milestone/current
Indicates an issue or PR that is being worked on at the current milestone.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the admin contract and tree type views, as well as improvements to form validation and database schema updates. The most important changes include updating URLs, adding form validation, and modifying the database schema.
URL Updates:
app/src/app/Views/Admin/Contract/Create.php
,Edit.php
, andContracts.php
to include the/admin
prefix for better organization and consistency. [1] [2] [3]Form Validation Enhancements:
app/src/public/assets/js/app.js
by adding reusable validation functions and event listeners for contract and tree type forms. This includes checks for empty fields, regex pattern validation, date range validation, positive integer validation, and maximum value validation.Database Schema Modifications:
contracts
table indatabase/start-scripts/0-init.sql
to change the data type ofstart_date
andend_date
fromtimestamp
todate
for better accuracy and consistency.UI and Form Adjustments:
app/src/app/Views/Admin/Contract/Create.php
andEdit.php
to improve user experience and error handling. [1] [2]app/src/app/Views/Admin/TreeType/Create.php
andEdit.php
to streamline the UI. [1] [2]