feat(ci): enhance workflows logic for pull requests and improve job c…

…onditions
Projecte-UrbanTree · Dec 4, 2024 · bc61500 · bc61500
1 parent 517c426
commit bc61500
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -20,7 +20,7 @@ jobs:
     permissions:
       pull-requests: read
     outputs:
-      images: ${{ steps.filter.outputs.changes }}
+      images: ${{ github.event_name == 'pull_request' && '["all"]' || steps.filter.outputs.changes }}
     steps:
       # https://github.com/actions/checkout/tree/11bd71901bbe5b1630ceea73d27597364c9af683
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -47,6 +47,8 @@ jobs:
       # https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#example-adding-configurations
       matrix:
         image: ${{ fromJSON(needs.changes.outputs.images) }}
+        exclude:
+          - image: all
         include:
           - image: urbantree
             context: ./app

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -11,7 +11,10 @@ jobs:
   urbantree:
     name: 🧪 UrbanTree
     runs-on: ubuntu-latest
-    if: ${{ contains(fromJSON(inputs.images), 'urbantree') }}
+    if: ${{ contains(inputs.images, 'all') || contains(fromJSON(inputs.images), 'urbantree') }}
+    defaults:
+      run:
+        working-directory: app
     steps:
       # https://github.com/actions/checkout/tree/11bd71901bbe5b1630ceea73d27597364c9af683
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -40,7 +43,6 @@ jobs:
 
       - name: 🧪 Run PHPUnit tests with coverage
         shell: bash
-        working-directory: app
         run: ./vendor/bin/phpunit --log-junit junit.xml --coverage-clover=coverage.xml
 
       # https://github.com/codecov/test-results-action/tree/9739113ad922ea0a9abb4b2c0f8bf6a4aa8ef820
@@ -61,7 +63,10 @@ jobs:
   api:
     name: 🧪 API
     runs-on: ubuntu-latest
-    if: ${{ contains(fromJSON(inputs.images), 'api') }}
+    if: ${{ contains(inputs.images, 'all') || contains(fromJSON(inputs.images), 'api') }}
+    defaults:
+      run:
+        working-directory: api
     steps:
       # https://github.com/actions/checkout/tree/11bd71901bbe5b1630ceea73d27597364c9af683
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -80,12 +85,10 @@ jobs:
 
       - name: 📦 Install Python dependencies
         shell: bash
-        working-directory: api
         run: pip install -r requirements-dev.txt
 
       - name: 🧪 Run Python tests with coverage
         shell: bash
-        working-directory: api
         run: pytest tests --cov=./src --cov-report=xml --junitxml=junit.xml
 
       # https://github.com/codecov/test-results-action/tree/9739113ad922ea0a9abb4b2c0f8bf6a4aa8ef820