Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rollup preserveEntrySignatures to neutral setting to silence warning output #990

Merged
merged 2 commits into from
Nov 3, 2022
Merged

update rollup preserveEntrySignatures to neutral setting to silence warning output #990

merged 2 commits into from
Nov 3, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 28, 2022 •
edited
Loading

Related Issue

#979 + ContributaryCommunity/www.contributary.community#115

To preserve the export signature of the entry module "src/index.js", an empty facade chunk was created. This often happens when creating a bundle for a web app where chunks are placed in script tags and exports are ignored. In this case it is recommended to set "preserveEntrySignatures: false" to avoid this and reduce the number of chunks. Otherwise if this is intentional, set "preserveEntrySignatures: 'strict'" explicitly to silence this warning.

Summary of Changes

  1. Set Rollup's preserveEntrySignatures setting to 'strict'

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) CLI alpha.2 v0.27.0 labels Oct 28, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Oct 28, 2022
@thescientist13 thescientist13 mentioned this pull request Oct 28, 2022
Merged
27 tasks
@thescientist13 thescientist13 changed the title update rollup preserveEntrySignatures to neutral setting to silence o… update rollup preserveEntrySignatures to neutral setting to silence warning output Nov 3, 2022
@thescientist13 thescientist13 force-pushed the enhancement/set-rollup-preserveEntrySignatures branch from 985fad6 to 63a9066 Compare November 3, 2022 00:29
@thescientist13 thescientist13 merged commit 2ee079e into release/0.27.0 Nov 3, 2022
@thescientist13 thescientist13 deleted the enhancement/set-rollup-preserveEntrySignatures branch November 3, 2022 00:43
@thescientist13 thescientist13 changed the title update rollup preserveEntrySignatures to neutral setting to silence warning output update rollup preserveEntrySignatures to neutral setting to silence warning output Nov 3, 2022
thescientist13 added a commit that referenced this pull request Nov 3, 2022
@thescientist13
update rollup preserveEntrySignatures to neutral setting to silence w…
c39262b 
…arning output (#990)

* update rollup preserveEntrySignatures to neutral setting to silence warning output

* comment config change
thescientist13 added a commit that referenced this pull request Nov 12, 2022
@thescientist13
update rollup preserveEntrySignatures to neutral setting to silence w…
ad480ca 
…arning output (#990)

* update rollup preserveEntrySignatures to neutral setting to silence warning output

* comment config change
thescientist13 added a commit that referenced this pull request Nov 23, 2022
@thescientist13
update rollup preserveEntrySignatures to neutral setting to silence w…
0595ba5 
…arning output (#990)

* update rollup preserveEntrySignatures to neutral setting to silence warning output

* comment config change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alpha.2 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.27.0
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13