Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade Greenwood v0.27.0 #115

Merged
merged 5 commits into from
Nov 23, 2022
Merged

upgrade Greenwood v0.27.0 #115

merged 5 commits into from
Nov 23, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 1, 2022 •
edited
Loading

Related Issue

Upgrade to latest version of Greenwood v0.27.0

Summary of Changes

  1. Clean up plugins in greenwood.config.js
  2. Upgrade web-test-runner.config.js accordingly

TODO

  1. Getting this warning from Rollup now 
    To preserve the export signature of the entry module "src/index.js", an empty facade chunk was created. This often happens when creating a bundle for a web app where chunks are placed in script tags and exports are ignored. In this case it is recommended to set "preserveEntrySignatures: false" to avoid this and reduce the number of chunks. Otherwise if this is intentional, set "preserveEntrySignatures: 'strict'" explicitly to silence this warning.
    Comparing before after, looks like there is an extra 10kb now uncompressed, but actually less in size when compressed?
    Screen Shot 2022-10-01 at 3 13 45 PM
    Screen Shot 2022-10-01 at 3 13 38 PM
  2. Also from the above, looks like webcomponents-loader.js and polyfills-support.js are being loaded twice? - must be the preload since it is happening in production too

@thescientist13 thescientist13 added chore needs upstream Dependency needed on Greenwood labels Oct 1, 2022
@thescientist13 thescientist13 self-assigned this Oct 1, 2022
@thescientist13 thescientist13 mentioned this pull request Oct 1, 2022
Merged
27 tasks
@thescientist13 thescientist13 mentioned this pull request Nov 3, 2022
Merged
@thescientist13 thescientist13 removed the needs upstream Dependency needed on Greenwood label Nov 4, 2022
@thescientist13 thescientist13 marked this pull request as ready for review November 21, 2022 19:46
@thescientist13 thescientist13 merged commit 15cb70a into master Nov 23, 2022
@thescientist13 thescientist13 deleted the chore/upgrade-greenwood-v0.27.0 branch November 23, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13