-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfc/issue 1167 content as data #1266
Merged
thescientist13
merged 36 commits into
release/0.30.0
from
rfc/issue-1167-content-as-data
Oct 18, 2024
Merged
rfc/issue 1167 content as data #1266
thescientist13
merged 36 commits into
release/0.30.0
from
rfc/issue-1167-content-as-data
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
question
Further information is requested
RFC
Proposal and changes to workflows, architecture, APIs, etc
CLI
Content as Data
breaking
feature
New feature or request
labels
Aug 11, 2024
Closed
16 tasks
thescientist13
added
the
website
Tasks related to the projects website / documentation
label
Aug 24, 2024
15 tasks
thescientist13
force-pushed
the
rfc/issue-1167-content-as-data
branch
from
September 6, 2024 21:45
b809f51
to
e916c3f
Compare
21 tasks
thescientist13
force-pushed
the
rfc/issue-1167-content-as-data
branch
from
September 21, 2024 17:50
44e7864
to
a070bc7
Compare
12 tasks
thescientist13
commented
Oct 9, 2024
packages/cli/src/lifecycles/graph.js
Outdated
collections[pageCollection].push(page); | ||
} | ||
|
||
compilation.collections = collections; | ||
} else { | ||
console.debug(`Unhandled extension (${extension}) for route => ${route}`); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
5 tasks
5 tasks
thescientist13
added a commit
that referenced
this pull request
Nov 2, 2024
* initial implementation of content collections with rich frontmatter support * add test cases for collections and prerendering * rename interpolateFrontmatter to activeFrontmatter * refactor id and lable graph properties * refactor graph title behavior * full graph and graphql plugin refactoring * update website for new graph refactoring * make sure active frontmatter is enabled for title substition * restore header nav ordering * comment cleanup * eslint ignore * support multiple import maps * add id to graph and refactor usage * refactoring pagePath to pageHref * update test cases * rename data/queries.js to client.js * handle default title from graph and provide default graph content as data in layouts * handle default title from graph and provide default graph content as data in layouts * refactor content as data handling to its own plugin * refactor for better windows interop * misc refactoring for active frontmatter * refactor outputPath to outputHref * add labels for custom side nav output * refresh content as data and GraphQL docs * update for new docs redirects * filter hidden files and improve unsupported page format detection message * opt-on content as data config and misc refactoring and TODOs * rename test case * update docs for content as data config option and patterns * conslidate content as data into dev server * misc refactoring * content as data import map test cases * fix selectors in test cases * rename test cases * consolidate configuration options and update docs * rename test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
CLI
Content as Data
documentation
Greenwood specific docs
feature
New feature or request
question
Further information is requested
RFC
Proposal and changes to workflows, architecture, APIs, etc
website
Tasks related to the projects website / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #1167
Summary of Changes
activeContent
)TODOs
interpolateFrontmatter
->activeFrontmatter
renamelinkheadings
->toc
What is the meaningful difference between- better generatedid
andlabel
?path
andfilename
? anything else worth cleaning up?id
, and gave better definitions to everything elseRenameindex
->order
renamemenu
->collection
defaulttitle
andlabel
should be the same and actually meaningful)Changepath
->url
(instance of URL or at least thehref
property for serializing)Something more predictable for- renamed tooutputPath
outputHref
it (- see nested SSR pages (and API routes) are throwing a module not found error (needs additional patch for adapters) #1223id
) doesn't "scale", e.g. for nested pagestitle
not populating as active frontmatter (is this because we set it tonull
?)unshift
on content as data in the graph?activeFrontmatter
when rendering page layout<title>
data
,route
, ???)+= 1
develop
specs?renameinterpolateFrontmatter
->activeFrontmatter
${graph.page.data.foo}
Response
merging isn't working? - seems to work fine 🤷♂️basePath
build graphQL resolvers off of greenwood internal functions / content API endpoint- I think would rather wait until support hot reloading content as data changes during development #1278move active frontmatter (back) to standard HTML plugin?- will leave it where it iscontentAsData
to link queries to specific page)Thoughts / Observations
globalThis
? - Content as Data v2 #1286fetch
requests, e.g.<script type="application/json" GWD-DATA ...></script>
graph
topages
instead? A graph implies nodes, some sort of linking structure, etc which it is definitely not in its current state. - Content as Data v2 #1286activeFrontmatter
+contentAsData
options? Maybe boil it down toactiveContent
? - we shall!prerender
vs SSR vs CSR) #951 - will handle this as part of Docs Page www.greenwoodjs.dev#31prerender
caveat - only your components run once, not your generic inline<script>
tags!<script type="application/json">
data-gwd-opt="static"
, should we create something likeuse static
? 🤔<my-heading><h1>Hello World!</h1></my-heading>
-><h1>Hello World!</h1>
🤔 🤔outputDir
,scratchDir
,userWorkspace
and append HrefoptimizedFileName
, etc