Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/issue 1223 support nested pages and API for and adapters #1237

Merged
merged 11 commits into from
Jun 26, 2024
Merged

bug/issue 1223 support nested pages and API for and adapters #1237

merged 11 commits into from
Jun 26, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 2, 2024 •
edited
Loading

Related Issue

resolves #1223 / #1226

Summary of Changes

  1. "Sync" API route bundle names based on Rollup bundling
  2. Add test cases for generic adapter specs
  3. Add test cases and refactor Netlify and Vercel adapters
  4. Documented basic build output

TODO

  1. Add test cases and refactor Vercel adapter
  2. fix lingering test case failure
  3. re-enable chunk it blocks
  4. we should get a real id from the graph (track in Content as Data #1167 )
  5. document build output

@thescientist13 thescientist13 added bug Something isn't working enhancement Improve something existing (e.g. no docs, new APIs, etc) CLI Adapter labels Jun 2, 2024
This was linked to issues Jun 2, 2024
nested SSR pages (and API routes) are throwing a module not found error (needs additional patch for adapters) #1223
Closed
improve naming for (nested) bundled SSR page and API route entry points to better reflect original file based routing name #1226
Closed
@thescientist13 thescientist13 added the documentation Greenwood specific docs label Jun 2, 2024
@thescientist13 thescientist13 mentioned this pull request Jun 2, 2024
Closed
@thescientist13 thescientist13 marked this pull request as ready for review June 2, 2024 13:03
@thescientist13 thescientist13 force-pushed the bug/issue-1223-support-nested-apis-and-adapters branch from 30716c4 to 2e9ace0 Compare June 23, 2024 13:11
@thescientist13 thescientist13 merged commit e3d42d3 into release/0.30.0 Jun 26, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1223-support-nested-apis-and-adapters branch June 26, 2024 01:22
@thescientist13 thescientist13 mentioned this pull request Aug 11, 2024
Merged
31 tasks
thescientist13 added a commit that referenced this pull request Nov 2, 2024
@thescientist13
bug/issue 1223 support nested pages and API for and adapters (#1237)
11e770c 
* nested API routes support

* nested API routes test case validation

* nested API routes test case validation

* nested SSR pages netlify adapter support

* nested SSR pages and API routes support and test cases for netlify adapter

* refactored and supported nested SSR pages for vercel adapter

* nested SSR page and API routes for vercel adapter

* restore adapter route chunk test cases

* check for API fragments

* document build output

* rebase a ronis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Adapter bug Something isn't working CLI documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) SSR
Projects
None yet
Milestone
No milestone
1 participant
@thescientist13