Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1234 refine spa local dev routing for html requests #1251

Conversation

thescientist13
Copy link
Member

Related Issue

related to #1234

Observed in AnalogStudiosRI/www.analogstudios.net#98 that with the removal of the break in the linked PR, API routes were getting caught by the SPA handler during development

Screenshot 2024-06-22 at 3 33 34 PM
Screenshot 2024-06-22 at 3 33 45 PM

Summary of Changes

  1. Make sure SPA routes are actually HTML requests
  2. Update test cases accordingly

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI labels Jun 22, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Jun 22, 2024
@thescientist13 thescientist13 marked this pull request as ready for review June 22, 2024 21:01
@thescientist13 thescientist13 mentioned this pull request Jun 26, 2024
39 tasks
@thescientist13 thescientist13 force-pushed the bug/issue-1234-refine--spa-local-dev-routing-for-html-requests branch from d4f5201 to a7b6b9b Compare June 26, 2024 01:44
@thescientist13 thescientist13 merged commit a901210 into release/0.30.0 Jun 26, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1234-refine--spa-local-dev-routing-for-html-requests branch June 26, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.4 bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.30.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant